Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add wildcard hostname support #769

Merged
merged 3 commits into from
Jun 23, 2023
Merged

Add wildcard hostname support #769

merged 3 commits into from
Jun 23, 2023

Conversation

sjberman
Copy link
Contributor

Problem: Until now, users were only able to use hostnames without wildcards, limiting their options.

Solution: We now support wildcard hostnames for HTTPRoutes and Gateway listeners.

Testing: Added unit tests and verified nginx config manually

Closes #478

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@sjberman sjberman requested a review from a team as a code owner June 20, 2023 22:22
@github-actions github-actions bot added documentation Improvements or additions to documentation enhancement New feature or request labels Jun 20, 2023
kate-osborn
kate-osborn requested changes Jun 21, 2023
View reviewed changes
internal/state/graph/httproute.go Outdated Show resolved Hide resolved
internal/state/graph/httproute.go Outdated Show resolved Hide resolved
internal/state/graph/httproute_test.go Show resolved Hide resolved
internal/state/graph/validation_test.go Show resolved Hide resolved
@sjberman sjberman force-pushed the feature/wildcard-hostnames branch from c2a527e to 51f28e0 Compare June 22, 2023 16:17
sjberman added 2 commits June 22, 2023 14:08
@sjberman
Add wildcard hostname support
170192d 
Until now, users were only able to use hostnames without wildcards, limiting their options.

We now support wildcard hostnames for HTTPRoutes and Gateway listeners.
@sjberman
Refactor matching and hostname specificity
03b4ed4
kate-osborn
kate-osborn requested changes Jun 22, 2023
View reviewed changes
internal/state/graph/httproute.go Outdated Show resolved Hide resolved
internal/state/graph/httproute.go Show resolved Hide resolved
internal/state/graph/httproute.go Outdated Show resolved Hide resolved
internal/state/graph/httproute.go Outdated Show resolved Hide resolved
@sjberman sjberman force-pushed the feature/wildcard-hostnames branch from 51f28e0 to aa1e79b Compare June 22, 2023 21:46
@sjberman sjberman merged commit b22d2b7 into nginxinc:main Jun 23, 2023
@sjberman sjberman deleted the feature/wildcard-hostnames branch June 23, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kate-osborn kate-osborn kate-osborn approved these changes

@pleshakov pleshakov pleshakov approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
NGINX Gateway Fabric
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Route and Listener wildcard hostnames
3 participants
@sjberman @pleshakov @kate-osborn